doc: clarify limitations of path.isAbsolute #61576
Open
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Author
|
Thanks for reviewing! Happy to update wording or make changes if needed. |
cjihrig
approved these changes
Jan 29, 2026
watilde
approved these changes
Jan 30, 2026
trivikr
reviewed
Jan 31, 2026
|
|
||
| The `path.isAbsolute()` method determines if the literal `path` is absolute. | ||
| Therefore, it’s not safe for mitigating path traversals. | ||
| Therefore, it’s not safe for mitigating path traversals attacks. This method only checks whether a path is absolute and does not validate whether it is safe to use. |
Member
There was a problem hiding this comment.
Remove redundant s and word wrap.
Suggested change
| Therefore, it’s not safe for mitigating path traversals attacks. This method only checks whether a path is absolute and does not validate whether it is safe to use. | |
| Therefore, it’s not safe for mitigating path traversal attacks. This method | |
| only checks whether a path is absolute and does not validate whether it | |
| is safe to use. |
Contributor
There was a problem hiding this comment.
I don't understand what's the point of the added test, isn't it just repeating what's already there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the documentation for
path.isAbsolute()by explicitly statingthat it only checks whether a path is absolute and does not validate whether the
path is safe to use.